<html>
<head><meta charset="utf-8"><title>rls-1.0 · t-compiler/rust-analyzer · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/index.html">t-compiler/rust-analyzer</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rls-1.2E0.html">rls-1.0</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="199375255"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rls-1.0/near/199375255" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> marmeladema <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rls-1.2E0.html#199375255">(Jun 01 2020 at 14:25)</a>:</h4>
<p>Hello everyone!</p>
<p>I know it might no be the right place to discuss first generation RLS, but i have migrated the <code>save_analysis</code> crate, which is used by RLS if I am not mistaken, to use the HIR tree instead of the AST: <a href="https://github.com/rust-lang/rust/pull/72882">https://github.com/rust-lang/rust/pull/72882</a><br>
I would like to know where/who/how could I properly test this change? It seems that there are not really a lot of those in rustc itself.</p>



<a name="199375404"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rls-1.0/near/199375404" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rls-1.2E0.html#199375404">(Jun 01 2020 at 14:26)</a>:</h4>
<p><span class="user-mention" data-user-id="153740">@Igor Matuszewski</span> maybe?</p>



<a name="199375479"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rls-1.0/near/199375479" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rls-1.2E0.html#199375479">(Jun 01 2020 at 14:27)</a>:</h4>
<p>Not sure if <code>./x.py test --stage 0 src/tools/rls</code> works, but that's the first thing I'd try</p>



<a name="199375622"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rls-1.0/near/199375622" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> marmeladema <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rls-1.2E0.html#199375622">(Jun 01 2020 at 14:29)</a>:</h4>
<p>Or those tests ran in CI? I'll run them locally anyway, its just to understand how confident i can be about the CI</p>



<a name="199375674"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rls-1.0/near/199375674" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rls-1.2E0.html#199375674">(Jun 01 2020 at 14:29)</a>:</h4>
<p>I think they are run by bors, but don't fail the merge when they fail (instead, the tool is marked as broken)</p>



<a name="199376033"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rls-1.0/near/199376033" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> marmeladema <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rls-1.2E0.html#199376033">(Jun 01 2020 at 14:32)</a>:</h4>
<p>Ok thanks! I've seen bors complaining about clippy/mirri being broken after a merge :)<br>
Also is there a more appropriate place to discuss rls/save_analysis?</p>



<a name="199376373"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rls-1.0/near/199376373" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> marmeladema <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rls-1.2E0.html#199376373">(Jun 01 2020 at 14:35)</a>:</h4>
<p>Damn i can't run tools/rls tests locally because it wants openssl and not libressl :) Have to fix that first</p>



<a name="199384186"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rls-1.0/near/199384186" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> marmeladema <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rls-1.2E0.html#199384186">(Jun 01 2020 at 15:39)</a>:</h4>
<p>Well running <code>./x.py test --stage 0 src/tools/rls</code> did not go well, some tests failed because of rustc version mismatch</p>



<a name="199384277"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rls-1.0/near/199384277" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> marmeladema <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rls-1.2E0.html#199384277">(Jun 01 2020 at 15:40)</a>:</h4>
<div class="codehilite"><pre><span></span><code>Processing message: Object({&quot;jsonrpc&quot;: String(&quot;2.0&quot;), &quot;method&quot;: String(&quot;textDocument/publishDiagnostics&quot;), &quot;params&quot;: Object({&quot;diagnostics&quot;: Array([Object({&quot;code&quot;: String(&quot;E0514&quot;), &quot;message&quot;: String(&quot;found crate `std` compiled by an incompatible version of rustc\n\nhelp: please recompile that crate using this compiler (rustc 1.45.0-dev)\nnote: the following crate versions were found:\n      crate `std` compiled by rustc 1.44.0-beta.752 (a7d891e31 2020-04-21): /home/adema/Sources/rust/build/x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-ddd4722641488d4f.rlib\n      crate `std` compiled by rustc 1.44.0-beta.752 (a7d891e31 2020-04-21): /home/adema/Sources/rust/build/x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-ddd4722641488d4f.so&quot;), &quot;range&quot;: Object({&quot;end&quot;: Object({&quot;character&quot;: Number(0), &quot;line&quot;: Number(0)}), &quot;start&quot;: Object({&quot;character&quot;: Number(0), &quot;line&quot;: Number(0)})}), &quot;severity&quot;: Number(1), &quot;source&quot;: String(&quot;rustc&quot;)})]), &quot;uri&quot;: String(&quot;file:///home/adema/Sources/rust/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/rlsit/t3/borrow_error/src/main.rs&quot;)})})
</code></pre></div>



<a name="199384539"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rls-1.0/near/199384539" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rls-1.2E0.html#199384539">(Jun 01 2020 at 15:42)</a>:</h4>
<p>yeah, same here, not sure what's going on</p>



<a name="199384572"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rls-1.0/near/199384572" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> marmeladema <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rls-1.2E0.html#199384572">(Jun 01 2020 at 15:42)</a>:</h4>
<p>I am re-trying with <code>--stage 1</code> instead, lets see</p>



<a name="199384839"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rls-1.0/near/199384839" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> marmeladema <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rls-1.2E0.html#199384839">(Jun 01 2020 at 15:44)</a>:</h4>
<p>Ah it errors too on some tests but for real this time :)</p>



<a name="199386978"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rls-1.0/near/199386978" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> marmeladema <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rls-1.2E0.html#199386978">(Jun 01 2020 at 16:01)</a>:</h4>
<p>So on test is randomly failing oO and the three others are consistently failing but they all contain a comment:</p>
<div class="codehilite"><pre><span></span><code>// FIXME: Without `all_targets=false`, this test will randomly fail.
</code></pre></div>



<a name="199387012"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rls-1.0/near/199387012" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> marmeladema <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rls-1.2E0.html#199387012">(Jun 01 2020 at 16:01)</a>:</h4>
<p>They seem to consistently fail now :D</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>